Navigator Team Progress for the week ending 05/31/2002
Lowlights
Bug 101955 : Middle-click -> Open in new tab/window fails for Mail/News URLs (better fix this time) Bug 137005: Change wording of "File as group" to "Bookmark this group of tabs".
Michael Enright (MichaelTEnright@netscape.com):
Researched technical possibilities for new projects.
Samir Gehani (sgehani@netscape.com):
- really fixed bug 86501, bookmarks truncated when disk full. nsOutputFileStream's inherited |error()| method only returns an error when there's a problem opening the file, turned out there was no built-in error reporting in the old stream classes for failed writes (due to disk full, etc). My patch for this bug builds this in. Just waiting for reviews...
- checked in darin's patch for fastload bug 142847, a null check for a crash launching mail
- bug 143118 (ongoing work) - tried to reproduce various types of fastload crash associated with |nsXULPrototypeCache::GetPrototype|, and was able to reproduce a crash loading addressbook after some effort. I've located and patched various places where the fastload deserialize is not being stopped completely if a failure occurs during the deserialization process, but am not quite done.
- reviewed Pierre Chanial's first round of large bookmark patches again.
Joe Hewitt (hewitt@netscape.com):
1. Re-worked new default browser pref UI again (bug 89907); hopefully for the last time.
2. Identified problem relating to working with Acrobat forms (and Acrobat in general); this is bug 115138.
3. Isolated problem with obsolete chrome registry entries that caused faulty UI (bug 130088); turned over to Joe Hewitt.
Steve Morse (morse@netscape.com):
Blake Ross (blaker@netscape.com):
Meet with UE to discuss options on the sidebar redesign.
Investigate adding preventdefault="true" to XBL handlers for the real (non-hack) fix to bug 74688.
jaggernaut:
Bug 148840: Add "Bookmark This Group of Tabs..." to Bookmarks menu
Bug 112769: [rfe] tab bar should have a "New Tab" button
MichaelTEnright:
Write up a log of exploration so far, and send out some maps of the design space, and pointers for the pioneer settlers to follow.
Hand off mail interaction solutions involvement to mail folks.
Hand off other bugs to appropriate engineers.
sgehani:
16256 Need to remove What's Related text from Smart Browsing preferences panel
143118 Various Trunk crashes [@ nsXULPrototypeCache::GetPrototype]
hewitt :
1. Get l10n changes in for deadline. This means expediting l10n change for bug 89907.
2. Get bug fixes for Mozilla 1.1alpha (whatever that is) by tomorrow's deadline.
3. Work on fixes for Acrobat interface problem(s).
morse:
- Get remaining [rtm] bugs checked in on the 1.0 branch (106123, 131481, 76621).
- Finish up remaining nsbeta1+ bugs (131651, 138237).
- Help investigate bug 76831 (long delay restoring window, appears focus-related).
varga:
Highlights
- Pierre Chanial fixed a slew of bookmark drag & drop bugs with his patch to Bug 137119. Many thanks Pierre, and well done! Trés bien!
- Christopher Aillon fixed the Download Manager's over-eager focussing, and helped fix and land patches for other bugs.
- Peter Annema came up with a better fix for middle-clicking links in mail.
- Ben Goodger came up with a fix for remaining Fastload XUL bugs. We decided we don't need to risk taking this on the branch for RTM, but his fixes will reduce noise and allow for smoother baking on the trunk. In any case, we have a 20% perf win in the bag for the point release!
- Bill Law finished implementing an easy way to set Navigator as default browser.
- Steve Morse checked in the new turbo model on the branch, fixing many bugs and opening up the possibility to enable QuickLaunch even for multi-profile users. He also updated the design spec to match.
- Blake Ross helped fix window.close behavior in tabbed browsing.
- Brian Ryner fixed some focus/blur bugs, and helped setup regular Chimera
builds.
- The Navigator team resolved 271 bugs fixing 35 of these.
Lowlights
- Way too many untriaged bugs, 748 in Bugzilla and we're currently only scanning for the most critical ones. Please nominate any you think need to be fixed for MachV; otherwise they may be lost in all the noise. Also, please check to see that they are at least as bad as the ones we already have.
Progress
Christopher Aillon:Peter Annema (jaggernaut@netscape.com):
Read UML, RDF, and XUL template tutorials
Reviewed bugs 55358, 101955, 115225, 133506, 147916
Worked with jag to come up with a hack for bug 74688
Landed patches to both trunk and branch for bugs 141333 and 145528, trunk only
for 143267
Bug 101955 : Middle-click -> Open in new tab/window fails for Mail/News URLs (better fix this time) Bug 137005: Change wording of "File as group" to "Bookmark this group of tabs".
Michael Enright (MichaelTEnright@netscape.com):
Researched technical possibilities for new projects.
Samir Gehani (sgehani@netscape.com):
-
Worked with dprice on mozilla 1.0 candidate installer bug 145776.
- really fixed bug 86501, bookmarks truncated when disk full. nsOutputFileStream's inherited |error()| method only returns an error when there's a problem opening the file, turned out there was no built-in error reporting in the old stream classes for failed writes (due to disk full, etc). My patch for this bug builds this in. Just waiting for reviews...
- checked in darin's patch for fastload bug 142847, a null check for a crash launching mail
- bug 143118 (ongoing work) - tried to reproduce various types of fastload crash associated with |nsXULPrototypeCache::GetPrototype|, and was able to reproduce a crash loading addressbook after some effort. I've located and patched various places where the fastload deserialize is not being stopped completely if a failure occurs during the deserialization process, but am not quite done.
- reviewed Pierre Chanial's first round of large bookmark patches again.
Joe Hewitt (hewitt@netscape.com):
worked on mach v bugs:Bill Law (law@netscape.com):
* bug 101968 - clodern theme in profiles shared between netcape/moz
* bug 130088 - prefs don't work when upgraded from 6 to 7
* worked on chimera bugs:
* 145803 - urlbar autocomplete (fixing bugs after initial landing)
* 145802 - go menu session history (some additional error checking)
1. Re-worked new default browser pref UI again (bug 89907); hopefully for the last time.
2. Identified problem relating to working with Acrobat forms (and Acrobat in general); this is bug 115138.
3. Isolated problem with obsolete chrome registry entries that caused faulty UI (bug 130088); turned over to Joe Hewitt.
Steve Morse (morse@netscape.com):
- Turbo Mode
Checked in new turbo model on the branch. Updated turbo-mode design documentation to reflect the new turbo model. Went through all open turbo bugs and closed those that were fixed by the new model. Notified turbo mailing list about the new model and how it affects existing bugs.
- Browser Latency
Worked with dp to try to nail this problem. Isolated it to the dispatching of an NS_GOTFOCUS event that occurs when processing WM_SETFOCUS. Made the key people aware of it and we are trying to determine a potential fix.
Received all approvals and checked patches for the following bugs into
the 1.0.1 branch
62348: Cookies don't work for sites with slash in query strings
145492 (was 130792): Cookies sent twice
138132: re-sort cookies by reverse status when using p3p
98673: reduce memory usage during turbo shutdown
135568: Task-menu flyouts don't match spec
146048/115818: image context menu is slow to appear
148196: Updated turbo spec
Checked into mozilla-org
Blake Ross (blaker@netscape.com):
- 128322 - history sidebar opens topmost link. Checked in on trunk. Thanks
to Neil for extending my patch to fix a related bug.
- 103452 - javascript window.close() should close tab, not window. Provided
xpapps portion of patch now that jst has done the necessary DOM work.
- 130008 - prefs not visible when upgrading from 6.0 to 6.01 to trunk. Began
working on the solution to this that we'll use for MachV (real solution requires
hard installer
Brian Ryner (bryner@netscape.com):
- Fixed bug 76621 (sidebar should not steal focus), checked in on the trunk.
- Came up with a fix for bug 138237 (focus disappears when opening a
link in a new tab), getting reviews.
- Got the fix for 133387 (incorrect cursor inside menus on Linux) onto
the 1.0 branch.
- Did some testing of patch for 131651 (incorrect blur events going to
popup windows).
- Helped out beard and mcafee with the Chimera branch/tinderbox/nightly
builds.
Jan Varga (varga@utcru.sk):
Priorities
Team
- Fix our nsbeta1+ bugs: 26 in Bugzilla
- Help triage our nsbeta1 nominations:
3 in Bugzilla,
- Triage untargeted bugs, nominate or move out as appropriate.
Meet with UE to discuss options on the sidebar redesign.
Investigate adding preventdefault="true" to XBL handlers for the real (non-hack) fix to bug 74688.
Bug 148840: Add "Bookmark This Group of Tabs..." to Bookmarks menu
Bug 112769: [rfe] tab bar should have a "New Tab" button
MichaelTEnright:
Write up a log of exploration so far, and send out some maps of the design space, and pointers for the pioneer settlers to follow.
Hand off mail interaction solutions involvement to mail folks.
Hand off other bugs to appropriate engineers.
sgehani:
- * Add pref for sidebar button and implement classic XBL/CSS
as part of
bugzilla 134345 <http://bugzilla.mozilla.org/show_bug.cgi?id=134345>.
* Drive reviews and checkins for nsbeta1+ bugs with patches: bugzilla 55358
<http://bugzilla.mozilla.org/show_bug.cgi?id=55358>, bugzilla 133506
<http://bugzilla.mozilla.org/show_bug.cgi?id=133506>, bugzilla 144494
<http://bugzilla.mozilla.org/show_bug.cgi?id=144494>
* Implement and performance test alternate strategy for bugzilla 55358
<http://bugzilla.mozilla.org/show_bug.cgi?id=55358>.
* Pick up on revised sidebar tab navigation work for bugzilla 127973
<http://bugzilla.mozilla.org/show_bug.cgi?id=127973>.
ben:
16256 Need to remove What's Related text from Smart Browsing preferences panel
143118 Various Trunk crashes [@ nsXULPrototypeCache::GetPrototype]
Need to discuss js deserialization failures with brendan (which are what I believe are causing the bug)
hewitt :
* finish my mach v bugs listed abovelaw:
1. Get l10n changes in for deadline. This means expediting l10n change for bug 89907.
2. Get bug fixes for Mozilla 1.1alpha (whatever that is) by tomorrow's deadline.
3. Work on fixes for Acrobat interface problem(s).
morse:
Fix long delay after long periods of inactivity (bug 76831).blaker:
cookperm.txt truncated when disk full (bug 145557)
remove understanding privacy
- still need to secure mac testing for my patch in 132027, my remaining nsbeta1+bryner:
bug...macheads have been busy the past few days.
- finish with 130008
- investigate 126826 (back/fwd not working), a bug I've been tracing since 6.0
days that I'd like to kill.
- Start working onsite in Mt View on 6/10
- Get remaining [rtm] bugs checked in on the 1.0 branch (106123, 131481, 76621).
- Finish up remaining nsbeta1+ bugs (131651, 138237).
- Help investigate bug 76831 (long delay restoring window, appears focus-related).
varga: